Bugfix - fix broken ember-data GitHub URLS #862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the file has packages already in the path, make sure we don't add duplicate packages via the mainDir function. Fixes an issue with ember data URLS having an incorrect 'packages/packages' in the GitHub source URL Example problem was https://api.emberjs.com/ember-data/4.10/classes/RecordArray
|
@runspired do you have any idea why there were recently some duplicate |
jaredgalanis
reviewed
May 1, 2023
jaredgalanis
requested changes
May 1, 2023
jaredgalanis
approved these changes
May 2, 2023
|
This is fixed in EmberData now emberjs/data#8598 |
|
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the file has packages already in the path, make sure we don't add duplicate packages via the mainDir function.
Fixes an issue with ember data URLS having an incorrect 'packages/packages' in the GitHub source URL
Example problem was
https://api.emberjs.com/ember-data/4.10/classes/RecordArray
Closes ember.js #20404